CF reviewing-unit-tests
Use when reviewing Vitest unit-test diffs in ComfyUI_frontend, especially new mocks, store tests, component tests, or bugfix regression tests.
Review for behavior and current repo rules, not motion.
As a process F 31/100 · No process to follow — References files that are not bundled: ../../../vitest.setup.ts, ../../../docs/guidance/testing-principles.md, ../../../docs/testing/vitest-patterns.md
How to improve
- The SKILL.md body is over 5,000 tokens: move reference detail into references/ and load it when needed.
- The text references files that are not there: add them or drop the references.
- Your own cases (evals/evals.json, 4–6 real requests with expected answers): the full check would then run those instead of a model-drafted suite.
- A spec.yaml with trigger phrases and assertions — a behaviour contract for CI; `skilltest init` writes a template.
Guard findings · 0
✓ No critical or high findings
Files scanned: 1. Evidence is masked. Grey chips explain why severity was lowered.
Against the Agent Skills spec
- warning
body-longSKILL.md body ≈ 5091 tokens (recommended < 5000); move details to references/ - warning
missing-refreference to a missing file: ../../../vitest.setup.ts - warning
missing-refreference to a missing file: ../../../docs/guidance/testing-principles.md - warning
missing-refreference to a missing file: ../../../docs/testing/vitest-patterns.md - warning
missing-refreference to a missing file: ../../../docs/testing/unit-testing.md - warning
missing-refreference to a missing file: ../../../docs/testing/store-testing.md - warning
missing-refreference to a missing file: ../../../docs/testing/component-testing.md - warning
missing-refreference to a missing file: ../../../src/utils/__tests__/litegraphTestUtils.ts - warning
missing-refreference to a missing file: ../../../docs/guidance/vitest.md - warning
missing-refreference to a missing file: ../../../vite.config.mts - warning
missing-refreference to a missing file: ../../../src/components/searchbox/v2/__test__/testUtils.ts - warning
missing-refreference to a missing file: ../../../docs/testing/litegraph-testing.md - warning
missing-refreference to a missing file: ../../../docs/guidance/typescript.md - note
edit-residuethe text marks something as outdated (lines 6, 44, 45, 53, 70, 146): check that old rules are not kept next to new ones — the full check reads the text for contradictions
Process rating: all ten parameters 31/100
- 0Tools and files. 12 referenced file(s) missing: ../../../vitest.setup.ts, ../../../docs/guidance/testing-principles.md, ../../../docs/testing/vitest-patterns.md
- 0Result and completion. Does not say what the result is
- 0Inputs and preconditions. Does not say what the process needs to start
- 0Failures and branches. Linear process with no failure handling
- 0Progress reporting. Says nothing while it works
- 20When it triggers. No condition that starts the skill
- 30Running it twice. 2 mutating operations with no state check
- 70Execution cost. Instruction body is 5091 tokens
- 100Steps. 44 steps
- 100Consistency. Name and required fields are in place
- low 11 top-level sections: this looks like several domains in one skill
Everything here is measured from the skill text rather than judged by a model, so the numbers are checkable. A parameter weighs more when it is a more common reason for the process to stall.
Quality signals
- +5Description has no quoted example phrases that should trigger the skill
- +4Description does not say when NOT to use the skill (false activations)
- +3Output format is not stated: the model decides each time
- +1No license
- +2Single-language instructions
- +3Description length 142: enough signal without eating the budget
- +4Structure: 19 headings
- +3Step-by-step instructions: 44 items
- +4Has examples (2 code blocks)
Quality base 70; lint remarks subtract, signals add up to 100. Result: 62.