AC requesting-code-review
Pre-commit review: security scan, quality gates, auto-fix.
Pre-commit review: security scan, quality gates, auto-fix.
As a process C 52/100 · Has gaps — weak spots: result and completion, when it triggers, inputs and preconditions
Runs in: Hermes Agent
How to improve
For the model run — optional
- Your own cases (evals/evals.json, 4–6 real requests with expected answers): the full check would then run those instead of a model-drafted suite.
- A spec.yaml with trigger phrases and assertions — a behaviour contract for CI; `skilltest init` writes a template.
Guard findings · 1
✓ No critical or high findings
Medium and low: 1
-
low Dangerous commands
cmd-eval-dynamicSKILL.md:248Dynamic code execution from decoded/untrusted input (documentation of a security skill)os.system(f"ls {user_input}")security skill
Files scanned: 1. Evidence is masked. Grey chips explain why severity was lowered.
Against the Agent Skills spec
✓ No remarks against the Agent Skills spec
Process rating: all ten parameters 52/100
- 0Result and completion. Does not say what the result is
- 0Inputs and preconditions. Does not say what the process needs to start
- 20When it triggers. No condition that starts the skill
- 30Running it twice. 9 mutating operations with no state check
- 60Tools and files. Uses tools (bash, git, python) that frontmatter does not declare
- 60Consistency. The Hermes dialect needs category and tags
- 100Steps. 23 steps
- 100Failures and branches. 1 branches, has a failure section
- 100Execution cost. Instruction body is 1991 tokens
- 100Progress reporting. Reports progress
- low 12 top-level sections: this looks like several domains in one skill
Everything here is measured from the skill text rather than judged by a model, so the numbers are checkable. A parameter weighs more when it is a more common reason for the process to stall.
Quality signals
- +5Description has no quoted example phrases that should trigger the skill
- +4Description does not say when NOT to use the skill (false activations)
- +3Description length 58: 120–800 characters recommended
- +3Output format is not stated: the model decides each time
- +2Single-language instructions
- +4Structure: 15 headings
- +3Step-by-step instructions: 23 items
- +4Has examples (11 code blocks)
- +1License stated
Quality base 70; lint remarks subtract, signals add up to 100. Result: 82.