AF named-persona-adversarial-review
Code review through the lens of real engineers' documented philosophies (Torvalds, Thompson, Carmack, Kent Beck, Jobs, Cagan). Complements abstract-role adversarial review with named, sourced perspectives. Use when automated review findings feel generic, when a PR has architectural or UX impact, or when the author wants pre-submit hardening beyond standard checks.
Code review through the lens of real engineers' documented philosophies (Torvalds, Thompson, Carmack, Kent Beck, Jobs, Cagan).
As a process F 33/100 · Will not run — References files that are not bundled: ../adversarial-reviewer/SKILL.md, ../code-reviewer/SKILL.md, ../senior-security/SKILL.md
How to improve
- The text references files that are not there: add them or drop the references.
- Your own cases (evals/evals.json, 4–6 real requests with expected answers): the full check would then run those instead of a model-drafted suite.
- A spec.yaml with trigger phrases and assertions — a behaviour contract for CI; `skilltest init` writes a template.
Guard findings · 0
✓ No critical or high findings
Files scanned: 2. Evidence is masked. Grey chips explain why severity was lowered.
Against the Agent Skills spec
- warning
missing-refreference to a missing file: ../adversarial-reviewer/SKILL.md - warning
missing-refreference to a missing file: ../code-reviewer/SKILL.md - warning
missing-refreference to a missing file: ../senior-security/SKILL.md - warning
missing-refreference to a missing file: ../../../productivity/andreessen/skills/andreessen/SKILL.md
Process rating: all ten parameters 33/100
- 0Tools and files. 4 referenced file(s) missing: ../adversarial-reviewer/SKILL.md, ../code-reviewer/SKILL.md, ../senior-security/SKILL.md
- 0Result and completion. Does not say what the result is
- 0Inputs and preconditions. Does not say what the process needs to start
- 0Failures and branches. Linear process with no failure handling
- 0Progress reporting. Says nothing while it works
- 20When it triggers. No condition that starts the skill
- 30Running it twice. 3 mutating operations with no state check
- 100Steps. 39 steps
- 100Consistency. Name and required fields are in place
- 100Execution cost. Instruction body is 2609 tokens
- medium Safety rules and hard prohibitions inside a skill: they belong in the system prompt, here they protect nothing
- low 13 top-level sections: this looks like several domains in one skill
Everything here is measured from the skill text rather than judged by a model, so the numbers are checkable. A parameter weighs more when it is a more common reason for the process to stall.
Quality signals
- +5Description has no quoted example phrases that should trigger the skill
- +4Description does not say when NOT to use the skill (false activations)
- +3Output format is not stated: the model decides each time
- +1No license
- +2Single-language instructions
- +3Description length 366: enough signal without eating the budget
- +4Structure: 18 headings
- +3Step-by-step instructions: 39 items
- +4Has examples (1 code blocks)
- +4Reference files are cited in the instructions (1 of 1)
Quality base 70; lint remarks subtract, signals add up to 100. Result: 76.