CD feishu-doc-reviewer
为智能体提供飞书文档读写能力：导出全文、读取评论与段落、写回修改并回复评论。
As a process D 48/100 · Unfinished process — weak spots: result and completion, when it triggers, inputs and preconditions
What is at stake
The skill contains fragments that, in the wrong hands, cost money or data. Below: what the installer risks and what the author should do.
The files contain someone else's key or token. If it is live, your agent will call third-party services under a stranger's identity; if it was revoked, the skill's scripts simply fail. Such a key often arrives with the author's whole workspace, personal data included.
The key is visible to everyone who downloaded the skill and has likely been copied by catalog-scanning bots already. Revoke it now, check bills and access logs, then reissue.
Below is the worst case for this category. The finding here is medium: the guard saw a sign, not a proof.
The instructions or scripts send data out: environment variables, keys, file contents, chat history. You may never notice, because the agent performs the upload as "part of the task".
If the upload is not needed for the task, remove it: catalogs flag such skills and delist them. If it is needed, name the destination explicitly, say what leaves the machine, and give the user a switch.
How to improve
- Address the high-severity findings: each costs 18 safety points. If one is a false positive, add the rule id to guard.allow in spec.yaml.
- Say in the description WHEN to use the skill ("use when…", example requests): that is the agent's main cue.
- Your own cases (evals/evals.json, 4–6 real requests with expected answers): the full check would then run those instead of a model-drafted suite.
- A spec.yaml with trigger phrases and assertions — a behaviour contract for CI; `skilltest init` writes a template.
Guard findings · 2
-
high Secrets in code
meta-credential-files.envCredential / dotenv files bundled with the skill (1).env
Medium and low: 1
-
medium Exfiltration
net-redirectable-api-keysrc/config.py:10Helper sends the API key to a host configured by an environment variable — the key can be redirected to another serverAPI key + configurable base URL from environment
Files scanned: 12. Evidence is masked. Grey chips explain why severity was lowered.
Against the Agent Skills spec
- warning
description-shortdescription under 40 chars: too little signal for triggering - warning
description-no-whendescription does not say WHEN to use the skill (no "use when")
Process rating: all ten parameters 48/100
- 0Result and completion. Does not say what the result is
- 0When it triggers. No condition that starts the skill
- 0Inputs and preconditions. Does not say what the process needs to start
- 0Failures and branches. Linear process with no failure handling
- 0Progress reporting. Says nothing while it works
- 30Running it twice. 16 mutating operations with no state check
- 100Tools and files. No external tools needed
- 100Steps. 32 steps
- 100Consistency. Name and required fields are in place
- 100Execution cost. Instruction body is 810 tokens
Everything here is measured from the skill text rather than judged by a model, so the numbers are checkable. A parameter weighs more when it is a more common reason for the process to stall.
Quality signals
- +5Description has no quoted example phrases that should trigger the skill
- +4Description does not say when NOT to use the skill (false activations)
- +3Description length 38: 120–800 characters recommended
- +3Output format is not stated: the model decides each time
- +1No license
- +2Single-language instructions
- +4Structure: 16 headings
- +3Step-by-step instructions: 32 items
- +4Has examples (5 code blocks)
Quality base 70; lint remarks subtract, signals add up to 100. Result: 61.