BC p-acp-agent-commerce
Build and review private A2A commerce workflows with P-ACP packages, privacy boundaries, Solana settlement plans, and receipt proofs.
Build and review private A2A commerce workflows with P-ACP packages, privacy boundaries, Solana settlement plans, and receipt proofs.
As a process C 58/100 · Has gaps — weak spots: when it triggers, inputs and preconditions, consistency
What is at stake
Medium-severity findings: the skill is probably honest, but read what alarmed the scanner.
Below is the worst case for this category. The finding here is medium: the guard saw a sign, not a proof.
The purpose itself is risky: wallets, browser password stores, offensive security. Even an honest implementation gives the agent access to things that cost money.
Explain in the description why the access is needed and how it is limited; add tests that show refusals on dangerous requests.
How to improve
- Say in the description WHEN to use the skill ("use when…", example requests): that is the agent's main cue.
- Your own cases (evals/evals.json, 4–6 real requests with expected answers): the full check would then run those instead of a model-drafted suite.
- A spec.yaml with trigger phrases and assertions — a behaviour contract for CI; `skilltest init` writes a template.
Guard findings · 1
✓ No critical or high findings
Medium and low: 1
-
medium Risky intent
intent-wallet-secretsreferences/safety-boundaries.md:9Handles crypto-wallet secrets (seed / mnemonic / private key) — a classic stealer target- request, print, store, or load a seed phrase or private key;
Files scanned: 5. Evidence is masked. Grey chips explain why severity was lowered.
Against the Agent Skills spec
- warning
description-no-whendescription does not say WHEN to use the skill (no "use when")
Process rating: all ten parameters 58/100
- 0Inputs and preconditions. Does not say what the process needs to start
- 0Progress reporting. Says nothing while it works
- 20When it triggers. No condition that starts the skill
- 30Running it twice. 5 mutating operations with no state check
- 40Consistency. Frontmatter name (p-acp-agent-commerce) differs from the folder (p-acp)
- 50Failures and branches. 0 branches, has a failure section
- 60Tools and files. Uses tools (bash) that frontmatter does not declare
- 100Steps. 45 steps
- 100Result and completion. Output format and completion criterion are stated
- 100Execution cost. Instruction body is 954 tokens
Everything here is measured from the skill text rather than judged by a model, so the numbers are checkable. A parameter weighs more when it is a more common reason for the process to stall.
Quality signals
- +5Description has no quoted example phrases that should trigger the skill
- +4Description does not say when NOT to use the skill (false activations)
- +4No input/output examples
- +1No license
- +2Single-language instructions
- +3Description length 133: enough signal without eating the budget
- +4Structure: 3 headings
- +3Step-by-step instructions: 45 items
- +3Output format is stated explicitly
- +4Reference files are cited in the instructions (3 of 3)
Quality base 70; lint remarks subtract, signals add up to 100. Result: 75.