BD code-reviewer
本技能从 6 个维度对代码进行全面审核:安全性、性能、代码质量、错误处理、测试和文档。适用于审核代码变更、Pull Request 或整个代码库(支持所有主流编程语言)。触发词包括:「帮我 review 这段代码」「检查安全问题」「审查这个 PR」「找出代码中的 Bug」,或用户请求代码质量分析时使用。技能内置自动化分析脚本、安全规则库、各语言最佳实践文档,并可生成可视化 HTML 审核报告。
本技能从 6 个维度对代码进行全面审核:安全性、性能、代码质量、错误处理、测试和文档。适用于审核代码变更、Pull Request 或整个代码库(支持所有主流编程语言)。触发词包括:「帮我 review 这段代码」「检查安全问题」「审查这个 PR」「找出代码中的…
As a process D 46/100 · Unfinished process — weak spots: result and completion, when it triggers, inputs and preconditions
How to improve
- Say in the description WHEN to use the skill ("use when…", example requests): that is the agent's main cue.
- Your own cases (evals/evals.json, 4–6 real requests with expected answers): the full check would then run those instead of a model-drafted suite.
- A spec.yaml with trigger phrases and assertions — a behaviour contract for CI; `skilltest init` writes a template.
Guard findings · 3
✓ No critical or high findings
Medium and low: 3
-
low Risky intent
intent-offensive-securityreferences/security-rules.md:10Offensive-security / dual-use content (legitimate for authorised testing; review intended use)| Privilege escalation | Role check missing before sensitive operation | All |
-
low Risky intent
intent-offensive-securityreferences/security-rules.md:197Offensive-security / dual-use content (legitimate for authorised testing; review intended use)| **High** | Sensitive data exposure, privilege escalation, SSRF, deserialization flaws | `pickle.loads(request_data)`, missing auth on admin endpoints |
-
low Risky intent
intent-offensive-securityreferences/severity-guide.md:43Offensive-security / dual-use content (legitimate for authorised testing; review intended use)**Definition:** Issues that could lead to data breaches, privilege escalation, or significant security weaknesses under certain conditions. Should be fixed before merge.
Files scanned: 9. Evidence is masked. Grey chips explain why severity was lowered.
Against the Agent Skills spec
- warning
description-no-whendescription does not say WHEN to use the skill (no "use when")
Process rating: all ten parameters 46/100
- 0Result and completion. Does not say what the result is
- 0Inputs and preconditions. Does not say what the process needs to start
- 0Failures and branches. Linear process with no failure handling
- 0Progress reporting. Says nothing while it works
- 20When it triggers. No condition that starts the skill
- 60Tools and files. Uses tools (python) that frontmatter does not declare
- 100Steps. 62 steps
- 100Consistency. Name and required fields are in place
- 100Execution cost. Instruction body is 1413 tokens
- 100Running it twice. No mutating operations
Everything here is measured from the skill text rather than judged by a model, so the numbers are checkable. A parameter weighs more when it is a more common reason for the process to stall.
Quality signals
- +5Description has no quoted example phrases that should trigger the skill
- +4Description does not say when NOT to use the skill (false activations)
- +3Output format is not stated: the model decides each time
- -5TODO / placeholder text left in the skill
- +1No license
- +2Single-language instructions
- +3Description length 198: enough signal without eating the budget
- +4Structure: 16 headings
- +3Step-by-step instructions: 62 items
- +4Has examples (5 code blocks)
- +4Reference files are cited in the instructions (4 of 4)
- +3All 3 scripts are documented
Quality base 70; lint remarks subtract, signals add up to 100. Result: 74.