BD msteams-china-patch
Patch OpenClaw to support Microsoft Teams China (世纪互联/21Vianet). 触发场景: (1) msteams webhook 401/AADSTS90002/AADSTS500011 错误; (2) JWT 验证失败/SigningKeyNotFoundError; (3) Teams 中国区首次配置; (4) OpenClaw 版本升级后 Teams 不工作; (5) 用户报告 Teams bot 无响应; (6) SSRF Blocked hostname 错误 (Blocked hostname (not in allowlist)); (7) Graph API 请求被安全策略阻止; (8) Teams bot 收到消息但无法回复 (sent-message state failed); (9) 版本升级自动检测与修复。此技能执行完整的诊断、修复、验证流程,支持自动检测版本变更并一键自动修复,输出标准化报告。
As a process D 41/100 · Unfinished process — weak spots: result and completion, when it triggers, inputs and preconditions
What is at stake
Medium-severity findings: the skill is probably honest, but read what alarmed the scanner.
Below is the worst case for this category. The finding here is medium: the guard saw a sign, not a proof.
The skill contains commands that delete files, rewrite disks or execute code fetched from the network. The agent may run them without asking if it believes the instructions require it.
Replace destructive commands with safe equivalents that ask for confirmation, scope them to one folder, and stop piping curl into a shell: pin a version and a checksum.
How to improve
- Say in the description WHEN to use the skill ("use when…", example requests): that is the agent's main cue.
- Your own cases (evals/evals.json, 4–6 real requests with expected answers): the full check would then run those instead of a model-drafted suite.
- A spec.yaml with trigger phrases and assertions — a behaviour contract for CI; `skilltest init` writes a template.
Guard findings · 4
✓ No critical or high findings
Medium and low: 4
-
medium Dangerous commands
cmd-shell-rcreferences/workflow.md:169Writes to a shell startup fileecho "export CLOUD=china" >> ~/.bashrc
-
medium Dangerous commands
cmd-shell-rcreferences/workflow.md:170Writes to a shell startup fileecho "export SERVICE_URL=https://smba.trafficmanager.cn/teams" >> ~/.bashrc
-
low Dangerous commands
cmd-shell-rcscripts/patch_all_v10.cjs:287Writes to a shell startup file (quoted — discussed, not commanded)execSync('echo "export CLOUD=china" >> ~/.bashrc', { stdio: 'pipe' });quoted -
low Dangerous commands
cmd-shell-rcscripts/patch_all_v10.cjs:288Writes to a shell startup file (quoted — discussed, not commanded)execSync('echo "export SERVICE_URL=https://smba.trafficmanager.cn/teams" >> ~/.bashrc', { stdio: 'pipe' });quoted
Files scanned: 22. Evidence is masked. Grey chips explain why severity was lowered.
Against the Agent Skills spec
- warning
description-no-whendescription does not say WHEN to use the skill (no "use when")
Process rating: all ten parameters 41/100
- 0Result and completion. Does not say what the result is
- 0Inputs and preconditions. Does not say what the process needs to start
- 0Failures and branches. Linear process with no failure handling
- 0Progress reporting. Says nothing while it works
- 20When it triggers. No condition that starts the skill
- 40Consistency. Frontmatter name (msteams-china-patch) differs from the folder (msteamschinaadapter)
- 60Tools and files. Uses tools (bash) that frontmatter does not declare
- 100Steps. 23 steps
- 100Execution cost. Instruction body is 3325 tokens
- 100Running it twice. No mutating operations
- low 13 top-level sections: this looks like several domains in one skill
Everything here is measured from the skill text rather than judged by a model, so the numbers are checkable. A parameter weighs more when it is a more common reason for the process to stall.
Quality signals
- +5Description has no quoted example phrases that should trigger the skill
- +4Description does not say when NOT to use the skill (false activations)
- +3Output format is not stated: the model decides each time
- -2localhost URLs: will not work for another user
- -216 emoji in the instructions: noise for the model
- -33 of 3 scripts are never mentioned in SKILL.md
- +1No license
- +2Single-language instructions
- +3Description length 442: enough signal without eating the budget
- +4Structure: 36 headings
- +3Step-by-step instructions: 23 items
- +4Has examples (18 code blocks)
- +4Reference files are cited in the instructions (4 of 4)
Quality base 70; lint remarks subtract, signals add up to 100. Result: 69.