SKILLEMALL.ai
GitHub ↗ RU Sign in

CD pr-checklist

Prepare a vLLM change for human PR review or re-review, or analyze an open pull request. Use before opening a PR, drafts included (e.g. `gh pr create`), or pushing review fixes, to check design fit, behavioral coverage, performance evidence, diff quality, and closure of previous feedback.

vllm-project/vllm Agent Skills author: vllm-project Apache-2.0 1 file body ≈ 4 633 tokens Open the sourcegithub.com↗ analyzed 5 d ago

Prepare a vLLM change for human PR review or re-review, or analyze an open pull request.

As a process D 42/100 · Unfinished process — References files that are not bundled: ../../../docs/contributing/model/basic.md, ../../../docs/design/model_runner_v2.md, ../../../docs/design/model_runner_v2.md

AnalyzerGitHubSoftware developmenttype and topics are labelled automatically from the skill text
Runs in: Claude / Claude Code ChatGPT / Codex Gemini CLI Cursor GitHub Copilot / VS Code Qwen Code Kimi Code CLI Z.ai (GLM) DeepSeek (Deep Code) Mistral Vibe LangChain (deepagents) OpenClaw Goose OpenCode
JSON
Technical rating
C
89/100
safety, quality, tests
Safety 60%
100
Quality 40%
72
Run on models
none yet
Process rating
D
42/100
Unfinished process
References files that are not bundled: ../../../docs/contributing/model/basic.md, ../../../docs/design/model_runner_v2.md, ../../../docs/design/model_runner_v2.md
Tools and files w 18
0
Inputs and preconditions w 11
0
Progress reporting w 2
0
the three weakest of ten parameters · all ten

How to improve

  1. The text references files that are not there: add them or drop the references.
For the model run — optional
  • Your own cases (evals/evals.json, 4–6 real requests with expected answers): the full check would then run those instead of a model-drafted suite.
  • A spec.yaml with trigger phrases and assertions — a behaviour contract for CI; `skilltest init` writes a template.

Guard findings · 0

✓ No critical or high findings

Files scanned: 1. Evidence is masked. Grey chips explain why severity was lowered.

Against the Agent Skills spec

  • warning missing-ref reference to a missing file: ../../../docs/contributing/model/basic.md
  • warning missing-ref reference to a missing file: ../../../docs/design/model_runner_v2.md
  • warning missing-ref reference to a missing file: ../../../docs/design/model_runner_v2.md
  • warning missing-ref reference to a missing file: ../../../tests/AGENTS.md
  • warning missing-ref reference to a missing file: ../../../docs/contributing/README.md
  • warning missing-ref reference to a missing file: ../../../docs/features/disagg_prefill.md
  • warning missing-ref reference to a missing file: ../../../docs/design/nixl_kv_push_connector.md
  • warning missing-ref reference to a missing file: ../../../docs/design/nixl_kv_cache_lease.md
  • note edit-residue the text marks something as outdated (lines 89): check that old rules are not kept next to new ones — the full check reads the text for contradictions

Process rating: all ten parameters 42/100

Will not run. References files that are not bundled: ../../../docs/contributing/model/basic.md, ../../../docs/design/model_runner_v2.md, ../../../docs/design/model_runner_v2.md
  • 0Tools and files. 8 referenced file(s) missing: ../../../docs/contributing/model/basic.md, ../../../docs/design/model_runner_v2.md, ../../../docs/design/model_runner_v2.md
  • 0Inputs and preconditions. Does not say what the process needs to start
  • 0Progress reporting. Says nothing while it works
  • 20When it triggers. No condition that starts the skill
  • 40Result and completion. Does not say what the result is
  • 50Failures and branches. 0 branches, has a failure section
  • 70Execution cost. Instruction body is 4633 tokens
  • 85Steps. 16 steps, 2 vague phrases
  • 100Consistency. Name and required fields are in place
  • 100Running it twice. Mutating operations check current state

Everything here is measured from the skill text rather than judged by a model, so the numbers are checkable. A parameter weighs more when it is a more common reason for the process to stall.

Quality signals

  • +5Description has no quoted example phrases that should trigger the skill
  • +4Description does not say when NOT to use the skill (false activations)
  • +3Output format is not stated: the model decides each time
  • +1No license
  • +2Single-language instructions
  • +3Description length 289: enough signal without eating the budget
  • +4Structure: 26 headings
  • +3Step-by-step instructions: 16 items
  • +4Has examples (1 code blocks)

Quality base 70; lint remarks subtract, signals add up to 100. Result: 72.